ability to check whether networkreply was really created ( rare test )

This commit is contained in:
Filip Bucek 2019-12-05 09:48:10 +01:00
parent b643f25421
commit 9088d93a4e
2 changed files with 7 additions and 3 deletions

View File

@ -27,7 +27,7 @@ RequestManager::RequestManager(QObject *parent)
*
* @param Request
*/
void RequestManager::processRequest(const std::shared_ptr<Request>& request)
bool RequestManager::processRequest(const std::shared_ptr<Request>& request)
{
QNetworkReply *reply = nullptr;
request->logStartTime();
@ -46,9 +46,11 @@ void RequestManager::processRequest(const std::shared_ptr<Request>& request)
reply = mNetworkAccessManager.put(request->networkRequest(), request->requestData());
} else {
qCritical(sdknetwork) << "Using request type:" << request->type() << "is not implemented";
return;
return false;
}
Q_ASSERT(reply);
// Adding reply to final request
reply->setParent(nullptr); // ensure QNetworkreply wont be deleted by QNetworkAccessManager ( it is parent of reply )
request->setNetworkReply(reply);
@ -67,6 +69,8 @@ void RequestManager::processRequest(const std::shared_ptr<Request>& request)
emit request->finished(request);
emit downloadFinished(request);
});
return true;
}
/**

View File

@ -19,7 +19,7 @@ class RequestManager : public QObject
public:
explicit RequestManager(QObject *parent = nullptr);
void processRequest(const std::shared_ptr<Request>& request);
bool processRequest(const std::shared_ptr<Request>& request);
bool ignoreSsl() const;