michalks/server-sdk
1
0
Fork 0
forked from ondra/server-sdk
Code Issues Pull Requests Projects Releases Wiki Activity

emitting error when SQL error

Browse Source
This commit is contained in:
Filip Bucek 2019-11-25 16:24:33 +01:00
parent eddfc401b0
commit 99089d1b12
3 changed files with 34 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
src/serversdk/databasemanager.cpp
View File

@ -128,6 +128,7 @@ QSqlQuery DatabaseManager::processResult(int res, const QSqlQuery &query) const
QString msg = QString("Source: Database Manager \nError --------\n%1\nSQL-------\n%2\n--------") QString msg = QString("Source: Database Manager \nError --------\n%1\nSQL-------\n%2\n--------")
.arg(query.lastError().text(), query.lastQuery()); .arg(query.lastError().text(), query.lastQuery());
qCDebug(sdkdb).noquote() << msg; qCDebug(sdkdb).noquote() << msg;
emit sqlError(query);
log(msg); log(msg);
} }
return query; return query;

2
src/serversdk/databasemanager.h
View File

@ -45,7 +45,7 @@ private:
void log(const QString &msg) const; void log(const QString &msg) const;
signals: signals:
void error(); void sqlError(const QSqlQuery &query);
private: private:
QString mConnectionName; QString mConnectionName;

35
test/auto/database/tst_sqlite.cpp
View File

@ -5,7 +5,6 @@
#include "serversdk/core.h" #include "serversdk/core.h"
// add necessary includes here // add necessary includes here
class Name : public serversdk::DatabaseTable { class Name : public serversdk::DatabaseTable {
Q_OBJECT Q_OBJECT
TABLE_PROPERTY(QString, uuid, set_uuid, QString()); TABLE_PROPERTY(QString, uuid, set_uuid, QString());
@ -26,6 +25,7 @@ private slots:
void createDb_test(); void createDb_test();
void createTable_test(); void createTable_test();
void updateTable_test(); void updateTable_test();
void fail_updateTable_test();
}; };
@ -124,8 +124,8 @@ void SqliteTest::updateTable_test()
name_B.set_name("TestnameB"); name_B.set_name("TestnameB");
utils.insertIntoTable(&name_A, "names"); QVERIFY2(utils.insertIntoTable(&name_A, "names").isActive(), "Successfull insert must return isActive sqlQuery");
utils.insertIntoTable(&name_B, "names"); QVERIFY2(utils.insertIntoTable(&name_B, "names").isActive(), "Successfull insert must return isActive sqlQuery");
// NOW UPDATING TABLE WITH name: NewName // NOW UPDATING TABLE WITH name: NewName
@ -148,6 +148,35 @@ void SqliteTest::updateTable_test()
QCOMPARE(dbB->jsonData(), name_B.jsonData()); QCOMPARE(dbB->jsonData(), name_B.jsonData());
} }
/** # Fail Update test
*
* Test isActive must be FALSE when not possible to update database table
*/
void SqliteTest::fail_updateTable_test()
{
// Prepare temporary path for database
QTemporaryDir dir;
QString dbpath = dir.path() + "/testdb.sqlite";
serversdk::DatabaseManager db;
db.openSQLite(dbpath);
QVERIFY(db.isOpen());
Name name_A, name_B;
// CREATE TABLE
serversdk::DatabaseUtils utils(&db);
QSqlQuery query = utils.createTable(&name_A, "names");
// INSERT INTO TABLE
const QString uuidA = "48f64fab-ba2a-40b5-8fbb-75361099dfb6";
name_A.set_uuid(uuidA);
name_A.set_id(2);
name_A.set_name("TestnameA");
QVERIFY2(!utils.insertIntoTable(&name_A, "nonexistenttable").isActive(), "Successfull insert must return isActive sqlQuery");
}
QTEST_APPLESS_MAIN(SqliteTest) QTEST_APPLESS_MAIN(SqliteTest)
#include "tst_sqlite.moc" #include "tst_sqlite.moc"