cppcheck: fixing warnings

src/colnod/datamanager.cpp

@@ -1,10 +1,11 @@
 #include "datamanager.h"
 
-DataManager::DataManager(const bool &dryMode)
+DataManager::DataManager(const bool &dryMode) :
-    :dryMode(dryMode)
+    db(std::make_shared<DatabaseManager>("192.168.1.94", "deloitte", "postgres", "34rjkciea12", dryMode)),
+    dryMode(dryMode)
 {
-    db = std::make_shared<DatabaseManager>("192.168.1.94", "deloitte", "postgres", "34rjkciea12", dryMode);
+    //    db = std::make_shared<DatabaseManager>("192.168.1.94", "deloitte", "postgres", "34rjkciea12", dryMode);
-    //db = std::make_shared<DatabaseManager>("localhost", "deloitte", "postgres", "34rjkciea12");
+    //    db = std::make_shared<DatabaseManager>("localhost", "deloitte", "postgres", "34rjkciea12");
     Logger::setDBMan(db);
     nextLastSync = db->getNow();
     lastSync = db->getLastSync();

src/colnod/datamanager.h

@@ -15,7 +15,7 @@ class DataManager : public QObject
     Q_OBJECT
 
 public:
-    DataManager(const bool& dryMode = false);
+    explicit DataManager(const bool& dryMode = false);
 
     void fillFullTokensColnod(const QString& jsonResponse);
 

src/colnod/entity.h

@@ -10,6 +10,7 @@
 class Entity : public QObject {
     Q_OBJECT
 public:
+    Entity() = default;
     using QObject::QObject;
 
     const QUuid &getId() const;

src/colnod/requestmanager.cpp

@@ -1,8 +1,8 @@
 #include "requestmanager.h"
 
 RequestManager::RequestManager()
+    : manager(std::make_unique<QNetworkAccessManager>())
 {
-    manager = std::make_unique<QNetworkAccessManager>();
     connect(manager.get(), &QNetworkAccessManager::sslErrors, this, &RequestManager::onSSLError);
 }
 

src/colnod/subject.h

@@ -12,7 +12,7 @@ class Subject : public Entity {
 public:
     using Entity::Entity;
     Subject() = default;
-    Subject(const QString& name);
+    explicit Subject(const QString& name);
 
     QString getEmail() const;
 

src/colnod/syncmanager.cpp

@@ -1,9 +1,9 @@
 #include "syncmanager.h"
 
-SyncManager::SyncManager(bool dryMode)
+SyncManager::SyncManager(bool dryMode) :
+    reqMan(std::make_unique<RequestManager>()),
+    dataMan( std::make_unique<DataManager>(dryMode))
 {
-    reqMan = std::make_unique<RequestManager>();
-    dataMan = std::make_unique<DataManager>(dryMode);
     this->dryMode = dryMode;
 
     connect(reqMan.get(), &RequestManager::error, this, &SyncManager::error);

src/colnod/syncmanager.h

@@ -9,8 +9,7 @@ class SyncManager : public QObject
     Q_OBJECT
 
 public:
-
+    explicit SyncManager(bool dryMode = false);
-    SyncManager(bool dryMode = false);
 
     void syncDataFromColnodToDB();
     void syncDataFromDBToColnod();

src/colnod/token.h

@@ -13,7 +13,7 @@ public:
 
     Token() = default;
     Token(const QString& name, QString tokenData, const QString& decription = "mobile");
-    Token(const QString& name);
+    explicit Token(const QString& name);
     ~Token() override;
 
     friend bool operator<(const Token &lToken, const Token &rToken){