ondra/server-sdk
1
0
Fork 1
mirror of https://gitlab.com/spaceti-app/integrations/common/server-sdk.git synced 2026-07-12 15:40:36 +02:00
Code Issues Projects Releases Wiki Activity

Merge branch 'feat/process-request' into 'master'

Browse Source 
ability to check whether networkreply was really created ( rare test )

See merge request spaceti-app/integrations/common/server-sdk!16
This commit is contained in:
Filip Bucek 2019-12-05 08:48:30 +00:00
commit 24d9578a4e
2 changed files with 7 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/serversdk/requestmanager.cpp
View File

@ -27,7 +27,7 @@ RequestManager::RequestManager(QObject *parent)
* *
* @param Request * @param Request
*/ */
void RequestManager::processRequest(const std::shared_ptr<Request>& request) bool RequestManager::processRequest(const std::shared_ptr<Request>& request)
{ {
QNetworkReply *reply = nullptr; QNetworkReply *reply = nullptr;
request->logStartTime(); request->logStartTime();
@ -46,9 +46,11 @@ void RequestManager::processRequest(const std::shared_ptr<Request>& request)
reply = mNetworkAccessManager.put(request->networkRequest(), request->requestData()); reply = mNetworkAccessManager.put(request->networkRequest(), request->requestData());
} else { } else {
qCritical(sdknetwork) << "Using request type:" << request->type() << "is not implemented"; qCritical(sdknetwork) << "Using request type:" << request->type() << "is not implemented";
return; return false;
} }
Q_ASSERT(reply);
// Adding reply to final request // Adding reply to final request
reply->setParent(nullptr); // ensure QNetworkreply wont be deleted by QNetworkAccessManager ( it is parent of reply ) reply->setParent(nullptr); // ensure QNetworkreply wont be deleted by QNetworkAccessManager ( it is parent of reply )
request->setNetworkReply(reply); request->setNetworkReply(reply);
@ -67,6 +69,8 @@ void RequestManager::processRequest(const std::shared_ptr<Request>& request)
emit request->finished(request); emit request->finished(request);
emit downloadFinished(request); emit downloadFinished(request);
}); });
return true;
} }
/** /**

2
src/serversdk/requestmanager.h
View File

@ -19,7 +19,7 @@ class RequestManager : public QObject
public: public:
explicit RequestManager(QObject *parent = nullptr); explicit RequestManager(QObject *parent = nullptr);
void processRequest(const std::shared_ptr<Request>& request); bool processRequest(const std::shared_ptr<Request>& request);
bool ignoreSsl() const; bool ignoreSsl() const;